Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example.cpp cmake #6076

Closed
wants to merge 1 commit into from
Closed

Fix example.cpp cmake #6076

wants to merge 1 commit into from

Conversation

NicolasGrosjean
Copy link

Issue

#5687

Tasklist

Requirements / Relations

No

@NicolasGrosjean
Fix example.cpp cmake #5687
92e56a2 
Fix example.cpp cmake according #5687
@NicolasGrosjean NicolasGrosjean changed the title Fix example.cpp cmake #5687 Fix example.cpp cmake Jul 8, 2021
@mjjbell
Copy link
Member

mjjbell commented Jul 8, 2021 •
edited
Loading

Thanks for the PR. I commented on #5687, this is a bug in the way that the libosrm.pc pkg-config file is generated.
A fix needs to be made in the OSRM build and not in the example build - the example shouldn't need to know about the Boost libs as they should be discovered via libosrm.pc

@mjjbell
Copy link
Member

mjjbell commented Sep 3, 2021

Obsoleted by #6083

@mjjbell mjjbell closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasGrosjean @mjjbell