Use Github Releases for hosting node binaries #6030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces S3 hosting of node binaries with Github Releases. `node-pre-gyp publish` works exclusively with S3, so upload step is now performed by the Travis deployment provider. The behaviour for the package user should not change. When building a new version tag, Travis will create a release for the tag if it does not already exist.
mjjbell
changed the title
mjjbell
force-pushed
the
mbell/node_github_releases
branch
from
99ba3f2 to
24ad672
Compare
…sonal credentials.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Replaces S3 hosting of node binaries with Github Releases.
node-pre-gyp publishworks exclusively with S3, so upload step is now performed by the Travis deployment provider.The behaviour for the package user should not change.
When building a new version tag, Travis will create a release for the tag if it does not already exist.
The secure token is my own personal token that has the
public_repoGithub OAuth permission.This is not ideal - Travis recommends to create a machine user for deployments. Someone with owner or admin permissions for Project-OSRM would need to do this.
Testing
I tested this on my own fork (see the test release from this branch as an example).
Tasklist
Requirements / Relations
Fixes #6013