Avoid copying ManyToMany table results #5923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Regardless of any copy elision on the returned pair value, the duration and distance results are always copied.
Fix this by passing rvalue references to
std::make_pair
.This could save copying a few megabytes on
Table
andTrip
requests with hundreds of sources/destinations and waypoints respectively. I haven't profiled this to see if this affects performance in any other way.Tasklist