Windows compilation fixes

[sivetic]

Been away a while, noticed a lot of new code. A few lines broke the windows compilation, mind pulling them in? Windows requires std::min/max/etc calls to be wrapped in ( ) as they're duplicate macro defs. Alternate fix is to use a #define NOMINMAX fix, but I already fixed a lot of instances by wrapping in parenthesis.

[DennisOSRM]

Did not know about the parentheses before. Will work something out for that. On another note: Is it possible to move the windows dependen stuff into a directory?

[sivetic]

I can work on that this week for sure. I think there are only a few small files. Ill push something out mon/tue.
------Original Message------
From: Project OSRM
To: sivetic
Subject: Re: [Project-OSRM] Windows compilation fixes (#55)
Sent: Dec 10, 2011 8:11 AM

Did not know about the parentheses before. Will work something out for that. On another note: Is it possible to move the windows dependen stuff into a directory?

---

Reply to this email directly or view it on GitHub:
#55 (comment)

Sent from my BlackBerry device on the Rogers Wireless Network

[sivetic]

Is this what you had in mind Dennis? There are only 3 files (getopt.h/c and unistd.h) that are windows specific.

[lekanteto]

There are still std::min/max/etc calls without () in the code :-(
Maybe an easier solution is to use NOMINMAX as a preprocessor definition in osrm.vsprops.

My other issue is that the macro DELETE is defined twice. Second time is in winnt.h.
By googling I found the folloing page:
http://stackoverflow.com/questions/1265666/reason-why-not-to-have-a-delete-macro-for-c

This sounds to me like there are better solutions than a macro to delete pointers. Unfotunately my C++ skills are to bad to come up with a solution myself.

[DennisOSRM]

Thanks for the link, lekanteto. The Windows port still needs work, which will have to wait until most of the other immediate bugs will be fixed.

[Delawen]

Any advance on this? I am facing the min/max calls problem with the latest version of the repository.

[DennisOSRM]

#ifndef NOMINMAX // Use the standard's templated min/max
#define NOMINMAX
#endif

[Delawen]

Thank you Dennis, will try with that def :)

Just in case someone here is interested: we posted a job offer to compile and generate a how to:
http://www.freelancer.com/projects/C-Programming-CPlusPlus-Programming/Compile-OSRM-project-Windows-Server.html

Of course we will share it with the community and try to maintain the Windows compilation part after this, but we thought that maybe a little push will be good right now.

[emiltin]

cool

[Delawen]

It's pretty laughable, but nobody seems to be able to compile it on Windows, not even for money.

So if anyone here have done this before and want easy money, we're open!! It can't be so hard...

[emiltin]

linux ftw:-)

my experience is that compiling can be hard. libraries, optimization, etc..

[emiltin]

*ftw

[sivetic]

I spent a considerable amount of effort compiling it on windows a while ago, and had it compiling, though it wasn't thoroughly tested as to whether it was working properly or not. I am too busy now, but I will see if I can make some time in the next few weeks to look at it again. I do know though that my git commits should be compilable, at least with code in that state and not updated.

[Delawen]

Good news everyone!

We finally have a working osrm on Win7. Will post instructions soon, when we clean and re-checked them.

[emiltin]

well done!

[tuure]

Is the instruction for binding osrm+Win7 available somewhere ?

[Delawen]

Here: https://github.com/DennisOSRM/Project-OSRM/wiki/Windows-Compilation

[DennisOSRM]

Please format the wiki page a little nicer. Right now it's not easy to read.

[juanluisrp]

Done! ;-)

[DennisOSRM]

Thanks

[DennisOSRM]

A couple of changes will appear in the coming days that will fix some issues with large data sets on Windows. Also see the experimental/cmake branch.

[DennisOSRM]

superseded by #998