Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bicycle profile: change barrier_whitelist to barrier_blacklist #5076

Merged
merged 2 commits into from
May 28, 2018
Merged

bicycle profile: change barrier_whitelist to barrier_blacklist #5076

merged 2 commits into from
May 28, 2018

Conversation

MichalPP
Copy link
Contributor

change barrier_whitelist to barrier blacklist in foot profile
fix #5067 and #3890 and #4823

@MichalPP MichalPP changed the title change barrier_whitelist to barrier_blacklist bicycle profile: change barrier_whitelist to barrier_blacklist May 14, 2018
@MichalPP
Copy link
Contributor Author

and maybe routing over barrier=some_tag should be allowed.

@MichalPP
blacklisting barriers allow routing
abd8409 
blacklisting barriers allow routing over barrier=some_tag
@TheMarex
Copy link
Member

@MichalPP thanks for taking a stab at this! Can you explain a little bit more why you think a blacklist is more appropriate? Our reasoning was that we should optimize for safety and should thus avoid paths with unknown obstacles.

@MichalPP
Copy link
Contributor Author

@TheMarex compared to car, going on foot/bicycle, you can physically pass basically any barrier (so access tags are respected). the whitelist would be very long.

plus blacklisting is a lot less prone to mistakes/typos/new invented tags.

@systemed
Copy link
Member

plus blacklisting is a lot less prone to mistakes/typos/new invented tags.

This is significant - car routing in/out of central London with OSRM was broken for several months because someone had invented a new tag (barrier=security_barrier I think) to represent an intermittently manned checkpoint (https://en.wikipedia.org/wiki/Traffic_and_Environmental_Zone).

@TheMarex
Copy link
Member

Hrm - yes that makes sense to me. Thanks for pushing this forward!

@TheMarex TheMarex merged commit 8dd8ee1 into Project-OSRM:master May 28, 2018
@ghoshkaj ghoshkaj added this to the 5.19.0 milestone Sep 7, 2018
datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this pull request Nov 19, 2020
@datendelphin
Merge tag 'v5.19.0'
0d12ed8 
  - Changes from 5.18.0:
    - Optimizations:
      - CHANGED: Use Grisu2 for serializing floating point numbers. [Project-OSRM#5188](Project-OSRM#5188)
      - ADDED: Node bindings can return pre-rendered JSON buffer. [Project-OSRM#5189](Project-OSRM#5189)
    - Profiles:
      - CHANGED: Bicycle profile now blacklists barriers instead of whitelisting them [Project-OSRM#5076
](Project-OSRM#5076)
      - CHANGED: Foot profile now blacklists barriers instead of whitelisting them [Project-OSRM#5077
](Project-OSRM#5077)
      - CHANGED: Support maxlength and maxweight in car profile [Project-OSRM#5101](Project-OSRM#5101]
    - Bugfixes:
      - FIXED: collapsing of ExitRoundabout instructions [Project-OSRM#5114](Project-OSRM#5114)
    - Misc:
      - CHANGED: Support up to 512 named shared memory regions [Project-OSRM#5185](Project-OSRM#5185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route over barrier=kerb
4 participants
@MichalPP @TheMarex @systemed @ghoshkaj