Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MAXIMAL_ALLOWED_SEPARATION_WIDTH to 12 meters #4835

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

oxidase
Copy link
Contributor

@oxidase oxidase commented Jan 29, 2018

Issue

The check should cover merging of roads at intersections similar
to https://www.openstreetmap.org/node/53020993#map=18/37.86590/-122.25083

Modified instruction for MAXIMAL_ALLOWED_SEPARATION_WIDTH:

Tasklist

@oxidase oxidase force-pushed the guidance/increase-MAXIMAL_ALLOWED_SEPARATION_WIDTH branch from 8fea994 to edaffd3 Compare January 29, 2018 13:55
@oxidase oxidase force-pushed the guidance/increase-MAXIMAL_ALLOWED_SEPARATION_WIDTH branch from edaffd3 to f47b0f1 Compare January 31, 2018 03:46
Copy link
Member

@TheMarex TheMarex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a spot check on the 12m map you posted and did not find any cases were the new instruction is worse than before.

@oxidase oxidase merged commit 91e6d68 into master Feb 1, 2018
@oxidase oxidase deleted the guidance/increase-MAXIMAL_ALLOWED_SEPARATION_WIDTH branch February 1, 2018 11:21
datendelphin added a commit to fossgis-routing-server/osrm-backend that referenced this pull request Jun 10, 2018
  - Changes from 5.15.2:
    - Guidance
      - ADDED Project-OSRM#4676: Support for maneuver override relation, allowing data-driven overrides for turn-by-turn instructions [Project-OSRM#4676](Project-OSRM#4676)
      - CHANGED Project-OSRM#4830: Announce reference change if names are empty
      - CHANGED Project-OSRM#4835: MAXIMAL_ALLOWED_SEPARATION_WIDTH increased to 12 meters
      - CHANGED Project-OSRM#4842: Lower priority links from a motorway now are used as motorway links [Project-OSRM#4842](Project-OSRM#4842)
      - CHANGED Project-OSRM#4895: Use ramp bifurcations as fork intersections [Project-OSRM#4895](Project-OSRM#4895)
      - CHANGED Project-OSRM#4893: Handle motorway forks with links as normal motorway intersections[Project-OSRM#4893](Project-OSRM#4893)
      - FIXED Project-OSRM#4905: Check required tags of `maneuver` relations [Project-OSRM#4905](Project-OSRM#4905)
    - Profile:
      - FIXED: `highway=service` will now be used for restricted access, `access=private` is still disabled for snapping.
      - ADDED Project-OSRM#4775: Exposes more information to the turn function, now being able to set turn weights with highway and access information of the turn as well as other roads at the intersection [Project-OSRM#4775](Project-OSRM#4775)
      - FIXED Project-OSRM#4763: Add support for non-numerical units in car profile for maxheight [Project-OSRM#4763](Project-OSRM#4763)
      - ADDED Project-OSRM#4872: Handling of `barrier=height_restrictor` nodes [Project-OSRM#4872](Project-OSRM#4872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants