Deprecate CoreCH, fallback to using CH #4598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxidase
approved these changes
Oct 12, 2017
There was a problem hiding this comment.
LGTM! Just some small changes in comments
But also
- a deprecation message is needed in change log
- line include/engine/search_engine_data.hpp:17 can be removed
- a deprecation comment at include/engine/engine_config.hpp:69
- scripts/gdb_printers.py:147 can be removed
| const DataFacade<corech::Algorithm> &facade, | ||
| const PhantomNodes &phantom_nodes); | ||
|
|
||
| template InternalRouteResult | ||
| directShortestPathSearch(SearchEngineData<ch::Algorithm> &engine_working_data, |
There was a problem hiding this comment.
can also be removed but requires a definition change above to
template <>
InternalRouteResult directShortestPathSearch(SearchEngineData<ch::Algorithm> &engine_working_data,
const DataFacade<ch::Algorithm> &facade,
const PhantomNodes &phantom_nodes)
| @@ -49,7 +49,7 @@ return_code parseArguments(int argc, | |||
| "Number of threads to use")( | |||
| "core,k", | |||
| boost::program_options::value<double>(&contractor_config.core_factor)->default_value(1.0), | |||
| "Percentage of the graph (in vertices) to contract [0..1]")( | |||
| "Percentage of the graph (in vertices) to contract [0..1]. Will always be 1.0")( | |||
There was a problem hiding this comment.
would be DEPRECATED Percentage of the graph (in vertices) to contract [0..1] better?
There was a problem hiding this comment.
| @@ -65,6 +65,7 @@ struct ContractorConfig final : storage::IOConfig | |||
|
|
|||
| unsigned requested_num_threads; | |||
|
|
|||
| // Deprecated | |||
There was a problem hiding this comment.
Please could you add also a release version when it is planed to remove, like // DEPRECATED to be removed in v6.0
There was a problem hiding this comment.
I'll open a follow up issue to track removal in v6 too
|
all internal usage of
EDIT: as discussed usage of core_factor should stay to support exclude flags, |
oxidase
requested changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #4444 and #4482
Tasklist
Requirements / Relations
cc @TheMarex @oxidase