handle throughabouts -- do not announce going through #4333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Further considerations ticketed in #4337 |
MoKob
force-pushed
the
guidance/throughabout
branch
from
e6dbc6b to
7111773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR resolves #3142 and resolves #4107. For a quick fix, this PR is walking the road of the most silent instructions possible. So for going through a throughabout, we will not see any instruction in the usual case.
This might result in confusion for strange maneuvers, but I would consider most of these to ne separate issues.
Compare screenshots for examples:
osm-link
going through the roundabout doesn't announce a maneuver. This might be overdoing the
silentpart. Should we go for a separate instruction here as inUse the throughlaneExits like these make counting exits really confusing. They could use some improvement.
Usually I would expect a normal
exitto ne on the outside of the roundabout. It would be nice to clarify this through lane here./cc @1ec5
Tasklist