Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyline6 support for the http REST API #4134

Merged
merged 5 commits into from
Jun 8, 2017
Merged

Polyline6 support for the http REST API #4134

merged 5 commits into from
Jun 8, 2017

Conversation

gardster
Copy link
Contributor

@gardster gardster commented Jun 7, 2017

Issue

Polyline6 support for the issue #4126

daniel-j-h
daniel-j-h reviewed Jun 7, 2017
View reviewed changes
Copy link
Member

@daniel-j-h daniel-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Could you add unit tests for the grammar in the url parser here and a changelog entry.

@gardster
Copy link
Contributor Author

gardster commented Jun 7, 2017

Ok. PTAL

@daniel-j-h
Copy link
Member

Looks good to me, thanks for the contribution!

@TheMarex TheMarex merged commit b8bb12b into Project-OSRM:master Jun 8, 2017
@gardster
Copy link
Contributor Author

gardster commented Jun 9, 2017

Thank you for fast review.

@daniel-j-h daniel-j-h added this to the 5.8.0 milestone Jun 15, 2017
@Zverik Zverik deleted the polyline_input branch February 19, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-j-h daniel-j-h daniel-j-h left review comments

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gardster @daniel-j-h @TheMarex