Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roundabouts with footway exits #4130

Merged
merged 2 commits into from
Jun 8, 2017
Merged

Fix roundabouts with footway exits #4130

merged 2 commits into from
Jun 8, 2017

Conversation

oxidase
Copy link
Contributor

@oxidase oxidase commented Jun 7, 2017

Issue

Assertion in #4129 occurs due to overwriting EnterRoundabout instruction at

if (!guidance::haveSameMode(exit_step, prev_step))
{
BOOST_ASSERT(leavesRoundabout(exit_step.maneuver.instruction));
prev_step.maneuver.instruction = exit_step.maneuver.instruction;
if (!entersRoundabout(prev_step.maneuver.instruction))
prev_step.maneuver.exit = exit_step.maneuver.exit;
exit_step.maneuver.instruction.type = TurnType::Notification;
step_index--;
}
, so enterRoundabout could correspond to another roundabout

Tasklist

  • add regression / cucumber cases (see docs/testing.md)
  • fix the issue
  • review
  • adjust for comments

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@oxidase oxidase force-pushed the fix/bike-footway-exit branch from 62b6c47 to 9404a99 Compare June 7, 2017 00:05
@oxidase oxidase added this to the 5.8.0 milestone Jun 7, 2017
@oxidase oxidase added the Review label Jun 7, 2017
@oxidase
Copy link
Contributor Author

oxidase commented Jun 7, 2017

@TheMarex the issue is related to #3766 The result for the query
screenshot from 2017-06-07 10-05-23

EDIT: please check expectation values because different modes change exits numbering and instructions for a,d, a,f, a,h announce always 1st exit

Copy link
Member

@TheMarex TheMarex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior of emitting an additional notification instruction makes sense.

@TheMarex TheMarex merged commit 03e83ec into master Jun 8, 2017
@TheMarex TheMarex deleted the fix/bike-footway-exit branch June 8, 2017 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants