NodeJs based Http Server #3887
Closed
NodeJs based Http Server #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-j-h
force-pushed
the
nodejs-server
branch
from
323c047 to
329a334
Compare
|
Stale. This is not specced out and feedback wrt. consolidating our internal server never happened. |
|
hmm. still sounds like a good idea, if the recommended way to run osm in production is node, not osrm-routed? |
|
Yes and that's why the issue is still open. I just closed this pull request since nothing was moving on that front and I don't want to keep it around in that state. Switching osrm-routed to a Node.js based server and away from the crufty C++ HTTP server is still on the todo list just not a priority for us atm since we already do have a functioning HTTP server on top of node-osrm. Would require more coordination with our internal API (cc @freenerd @miccolis). |
|
i see, makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3832.
Tasklist