Add error logging for missing osrm file to library tests #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Looks good! There is already a PR for the issue you are referencing #3698. |
karenzshea
force-pushed
the
library-test-trap
branch
from
5e39051 to
dfa2a99
Compare
TheMarex
pushed a commit
that referenced
this pull request
Feb 13, 2017
raymond0
added a commit
to raymond0/osrm-backend
that referenced
this pull request
Mar 2, 2017
…aterides-buildmain Broke city/country, but it was broken anyway. * develop-ultimaterides-560-untouched: (236 commits) clamp speed value to js max Updates TBB to latest stable version for 5.6 release expose data about turning onto restricted roads to turn function Updates sol2 to v2.15.8, resolves Project-OSRM#3733 reduce verbosity of use-lane in combination with lane-anticipation Update http.md Allow routing on toll roads by default (Project-OSRM#3712) add unit test for annotations=true returning all annotations parse parameters.annotations into AnnotationsType::All add error logging for missing osrm file to library tests (Project-OSRM#3704) use qi - parser to work with 0 speed file lines clang format round speed to 1 decimal place add unit test to check that speeds are equal to distance/duration return speed annotations Unit testing docs (Project-OSRM#3698) Update http.md comments fix handling none-tags in presence of multiple turns within add failing test ... # Conflicts: # .travis.yml # CHANGELOG.md # features/guidance/anticipate-lanes.feature # features/guidance/dedicated-turn-roads.feature # features/guidance/turn-angles.feature # include/engine/datafacade/shared_memory_datafacade.hpp # include/extractor/extraction_way.hpp # include/extractor/guidance/intersection.hpp # include/extractor/internal_extractor_edge.hpp # profiles/bicycle.lua # src/engine/guidance/lane_processing.cpp # src/extractor/extraction_containers.cpp # src/extractor/extractor_callbacks.cpp # src/extractor/guidance/turn_handler.cpp # src/extractor/scripting_environment_lua.cpp # src/tools/extract.cpp # src/tools/store.cpp # unit_tests/library/tile.cpp # unit_tests/util/coordinate_calculation.cpp
raymond0
added a commit
to raymond0/osrm-backend
that referenced
this pull request
Mar 2, 2017
…aterides-maptool * develop-ultimaterides-560-untouched: (236 commits) clamp speed value to js max Updates TBB to latest stable version for 5.6 release expose data about turning onto restricted roads to turn function Updates sol2 to v2.15.8, resolves Project-OSRM#3733 reduce verbosity of use-lane in combination with lane-anticipation Update http.md Allow routing on toll roads by default (Project-OSRM#3712) add unit test for annotations=true returning all annotations parse parameters.annotations into AnnotationsType::All add error logging for missing osrm file to library tests (Project-OSRM#3704) use qi - parser to work with 0 speed file lines clang format round speed to 1 decimal place add unit test to check that speeds are equal to distance/duration return speed annotations Unit testing docs (Project-OSRM#3698) Update http.md comments fix handling none-tags in presence of multiple turns within add failing test ... # Conflicts: # include/util/fingerprint.hpp # src/util/fingerprint.cpp
raymond0
added a commit
to raymond0/osrm-backend
that referenced
this pull request
Mar 3, 2017
…aterides-app * develop-ultimaterides-560-untouched: (236 commits) clamp speed value to js max Updates TBB to latest stable version for 5.6 release expose data about turning onto restricted roads to turn function Updates sol2 to v2.15.8, resolves Project-OSRM#3733 reduce verbosity of use-lane in combination with lane-anticipation Update http.md Allow routing on toll roads by default (Project-OSRM#3712) add unit test for annotations=true returning all annotations parse parameters.annotations into AnnotationsType::All add error logging for missing osrm file to library tests (Project-OSRM#3704) use qi - parser to work with 0 speed file lines clang format round speed to 1 decimal place add unit test to check that speeds are equal to distance/duration return speed annotations Unit testing docs (Project-OSRM#3698) Update http.md comments fix handling none-tags in presence of multiple turns within add failing test ... # Conflicts: # include/engine/guidance/assemble_geometry.hpp # include/engine/plugins/trip.hpp # include/engine/routing_algorithms/alternative_path.hpp # include/engine/routing_algorithms/direct_shortest_path.hpp # include/engine/routing_algorithms/map_matching.hpp # include/engine/routing_algorithms/routing_base.hpp # include/engine/routing_algorithms/shortest_path.hpp # include/util/fingerprint.hpp # src/engine/engine.cpp # src/engine/plugins/trip.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3697
Not very sustainable/helpful to continue telling people to read the
.travis.ymlfileTasklist