Offset turn angle into +/-180 range correctly #2922
Closed
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2918. Turn angles were being subtracted from 180 before being passed into the lua
turn_penalty
function, which is possibly how the the oldturn_penalty
function expected them (essentially flipped, as an angle of 0 became 180 and an angle of 180 became 0). The new function expects values between -180 and 180.h/t to @jakepruitt for help with debugging this
Tasklist
Requirements / Relations
https://github.com/Project-OSRM/osrm-backend/milestone/16