Offset turn angle into +/-180 range correctly #2922
Conversation
|
For the record, the graphed output of the new turn function looks more or less as expected; mirrored increase of penalties for sharper angles, slightly more expensive for left turns.
|
| const int32_t turn_penalty = | ||
| scripting_environment.GetTurnPenalty(180. - turn.angle); | ||
| scripting_environment.GetTurnPenalty(turn_angle); |
There was a problem hiding this comment.
might I ask where this is coming from? As you can see in #2918, I have made tests using exactly 180-turn.angle and you get just the results we want.
From my tests an angle of 180 (resulting in 0 as call argument) is getting a turn penalty of zero.
From your new call value, we would get 7.4 seconds for going straight.
Osrm assumes 180 as angle for going straight. The turn function in the profile expects 0 for going straight.
The angle change is broken here.
|
The obvious check here: https://travis-ci.org/Project-OSRM/osrm-backend/jobs/160304407#L3993 where you can see that https://github.com/Project-OSRM/osrm-backend/blob/master/features/bicycle/maxspeed.feature#L41-L48 is getting penalised now. Going straight didn't experience a penalty before, now it does. |
|
As described in #2918 (comment), we probably need a higher based penalty and probably additional penalties. The turn function itself is correct though. OSRM simply has a different internal model than the external model to represent turn angles. A turn-angle in OSRM is modelled from |
Just to clarify, is this 180 the number passed into the lua function? or the angle in the edge-based-graph-factory? |
Issue
Fixes #2918. Turn angles were being subtracted from 180 before being passed into the lua
turn_penaltyfunction, which is possibly how the the oldturn_penaltyfunction expected them (essentially flipped, as an angle of 0 became 180 and an angle of 180 became 0). The new function expects values between -180 and 180.h/t to @jakepruitt for help with debugging this
Tasklist
Requirements / Relations
https://github.com/Project-OSRM/osrm-backend/milestone/16