Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/another typo #2853

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Fix/another typo #2853

merged 1 commit into from
Sep 5, 2016

Conversation

MoKob
Copy link

@MoKob MoKob commented Sep 5, 2016

Issue

Followup on #2850

Tasklist

  • add regression / cucumber cases (see docs/testing.md)
  • review
  • adjust for for comments

@MoKob MoKob added this to the 5.4.0 milestone Sep 5, 2016
When I route I should get
| waypoints | route | turns | lanes |
| a,d | road,turn,turn | depart,turn left,arrive | ,left:true straight:false, |
| a,c | road,road | depart,arrive | , |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no lanes here since going straight is obvious and we silence lanes for this? It should be still on the intersection array and at some point we have to test for this, correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but unrelated change, see #2702

@MoKob MoKob merged commit be266c7 into master Sep 5, 2016
@MoKob MoKob deleted the fix/another-typo branch September 6, 2016 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants