Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on CentOS #2805

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Conversation

sandra-thieme
Copy link
Contributor

Issue

Fixes build on CentOS systems which doesn't have gcc ready for C++14 yet.

Fixes issue #2804

@TheMarex
Copy link
Member

Doesn't c++1y mean c++11 on older compilers? We switched to C++14 a while ago and just didn't get around to clean up the legacy code that backported some 14 functionality (e.g. http://en.cppreference.com/w/cpp/memory/unique_ptr/make_unique)

@MoKob
Copy link

MoKob commented Aug 24, 2016

From what I've read c++1y is the respective draft of c++14 just like c++11 was referred to by c++0x. Using a draft only does not seem a valid step in our progression to me.

@sandra-thieme
Copy link
Contributor Author

This is a change proposed by @daniel-j-h yesterday in irc:

11:56:40 <   danieljh> rkcpi: if it works fine with "c++1y" instead can you open a pull request with that change and see how travis likes it?

Is there another valid approach to still be able to build with gcc on CentOS?

@TheMarex
Copy link
Member

I'm fine with merging this, I confused c++0x with c++1y. Just note that builds for older compiler could break.

@TheMarex
Copy link
Member

Merging here. Note that on newer compiler c++1y is just an alias for c++14 so it doesn't change anything for our current setup.

@TheMarex TheMarex merged commit cb57cca into Project-OSRM:master Aug 25, 2016
@sandra-thieme sandra-thieme deleted the centos-build-fix branch August 26, 2016 06:56
springmeyer pushed a commit to Project-OSRM/node-osrm that referenced this pull request Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants