[Ready] Emit Merge for Motorways only #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoKob
force-pushed
the
guidance/only-merge-motorways
branch
4 times, most recently
from
43fa8dd to
54f6c1a
Compare
MoKob
changed the title
| } | ||
| else | ||
| { | ||
| const double constexpr MAX_COLLAPSE_DSTANCE = 30; |
TheMarex
force-pushed
the
guidance/only-merge-motorways
branch
from
54f6c1a to
c511d5e
Compare
| @@ -62,6 +63,16 @@ inline void print( const extractor::guidance::Intersection & intersection ) | |||
| std::cout << std::flush; | |||
| } | |||
|
|
|||
| inline void print( const NodeBasedDynamicGraph &node_based_graph, const extractor::guidance::Intersection & intersection ) | |||
daniel-j-h
force-pushed
the
guidance/only-merge-motorways
branch
from
c511d5e to
66e5af3
Compare
|
Resolved the two nitpicks I had with this. |
daniel-j-h
changed the title
| // since `distance` does not refer to an actual distance but rather to the | ||
| // duration/weight of the traversal. We can only approximate the distance here | ||
| // or actually follow the full road. When 2399 lands, we can exchange here for a | ||
| // precalculated distance value. |
There was a problem hiding this comment.
I don't see how 2399 helps here. On the contrary the distance here seems more correct?
TheMarex
force-pushed
the
guidance/only-merge-motorways
branch
from
a3c2880 to
c471849
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge paradigm in its current implementation seems confusing.
In cases where we take a very slight turn onto a through street, the instruction is technically a merge onto a street.
However, the merge paradigm of merging to the left on a slight right turn seems to confuse more than it helps.
This PR changes the paradigm of merge to only consider motorway-like ramps for merging and emitting an instruction to
go straightonto these merging situations.It is based on #2586