Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature name to vector tiles #2488

Merged
merged 1 commit into from
Jun 10, 2016
Merged

Conversation

vkurchatkin
Copy link
Contributor

No description provided.

@TheMarex
Copy link
Member

@danpat do you think this makes sense w.r.t. to vector tile size?

@vkurchatkin
Copy link
Contributor Author

@TheMarex it probably makes sense to include names only on larger zoom levels

@danpat
Copy link
Member

danpat commented Jun 10, 2016

I think this is probably better achieved by using a separate basemap layer from a regular tileserver. The debug tiles are really just to expose OSRM-internal data that's not available elsewhere (speeds, durations, turn costs, etc). This is what the debug map at http://map.project-osrm.org/debug/ does, it allows plenty of context.

The tiles are already pretty heavy - adding name data to every single segment will only make that worse. Additionally, the way the geometries are segmented means that label placement will be really terrible - labels won't follow curves, and there will be lots of collisions leading to pretty random label appearance.

@vkurchatkin Thanks for the contribution, but I think we'll hold off on this change for the moment.

@danpat danpat closed this Jun 10, 2016
@vkurchatkin
Copy link
Contributor Author

@danpat thanks for the feedback!

The debug tiles are really just to expose OSRM-internal data that's not available elsewhere (speeds, durations, turn costs, etc).

Name is kind of internal, because it can be changed in profile script. I was trying to use it to attach some data (way id, for example) and needed a way to visualize.

the way the geometries are segmented means that label placement will be really terrible

Probably true, I've tried only to access it programmatically on mouse events.

@danpat
Copy link
Member

danpat commented Jun 10, 2016

@vkurchatkin ah, I see, hmm, interesting use-case.

With that in mind, I'm 👍 on this change. Merging now :-)

@danpat danpat reopened this Jun 10, 2016
@danpat danpat merged commit 6bdfe68 into Project-OSRM:master Jun 10, 2016
@danpat danpat mentioned this pull request Mar 8, 2017
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants