Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/json lib interface #1292

Merged
merged 12 commits into from
Jan 6, 2015
Merged

Feature/json lib interface #1292

merged 12 commits into from
Jan 6, 2015

Conversation

DennisOSRM
Copy link
Collaborator

  • make output generation in Plugins/*.h format agnostic
  • implement output format specific code in calling code:
    • RequestHandler
    • Tools/simpleclient.cpp
    • Node bindings
    • add xml/gpx rendering for JSON Container
    • replace hand-rolled GPX generator

supersedes #1261

@DennisOSRM DennisOSRM mentioned this pull request Nov 25, 2014
Closed
@TheMarex
Copy link
Member

👍 This will also make my life easier with route-sketch, as the json object is directly exposed.

@DennisOSRM
Copy link
Collaborator Author

Happy to hear. It was about time to get rid of that. The passing of strings made sense in the past but the code base has changed tremendously in the past 12-18 months

@DennisOSRM DennisOSRM force-pushed the feature/json_lib_interface branch 2 times, most recently from f7e6923 to 2c9fc6a Compare November 26, 2014 12:43
@DennisOSRM DennisOSRM force-pushed the feature/json_lib_interface branch from 2c9fc6a to 2b06d39 Compare December 17, 2014 18:15
@DennisOSRM
Copy link
Collaborator Author

rebased onto develop, bringing in latest changes. One test should fail at this point.

@DennisOSRM DennisOSRM force-pushed the feature/json_lib_interface branch 2 times, most recently from 64c5f5f to 5d28e09 Compare December 23, 2014 17:50
This was referenced Jan 2, 2015
Closed
Closed
@DennisOSRM DennisOSRM force-pushed the feature/json_lib_interface branch from 5d28e09 to be63939 Compare January 6, 2015 12:36
@DennisOSRM
Copy link
Collaborator Author

Again, rebased onto develop after recent release. Once the CIs complete, this is good to merge.

cc: @TheMarex

@TheMarex
Copy link
Member

TheMarex commented Jan 6, 2015

👍

DennisOSRM added a commit that referenced this pull request Jan 6, 2015
@DennisOSRM
Merge pull request #1292 from Project-OSRM/feature/json_lib_interface
e296264 
Feature/json lib interface
@DennisOSRM DennisOSRM merged commit e296264 into develop Jan 6, 2015
@DennisOSRM DennisOSRM deleted the feature/json_lib_interface branch January 6, 2015 14:28
@DennisOSRM
Copy link
Collaborator Author

And we are live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DennisOSRM @TheMarex