-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor codebase to use std::optional instead of boost::optional #6551
Comments
Can I try to work on this? Which part of the codebase should I be looking at? |
GSoC has an application process, which we will follow. We’ll make an announcement as soon as that starts. |
I might be able to work on this. Is it available? |
It is. Do you want to be assigned? |
oops, I already have some progress on this issue |
@nilsnolde sorry for my previous misguiding comment. @code-sparsh It's fine that you take this issue! I will find another issue to work on later. Actually I haven't dig into the |
@97littleleaf11 Oh okay. If you already have some progress, it's fair that you take the issue because I haven't started yet. Regarding the Boost.Spirit, I did some research on it. I think it would require some extra workarounds to be able to support std::optional. That might add some extra boilerplate to the code. I don't know if that's feasible or not, because I am just a beginner in this. |
@code-sparsh Thanks for your information! Yeah, someone might add a boilerplate for std::optional like this boostorg/spirit#270 (comment) . Also need to check the correct overloading func. I haven't made it and found it's a little bit beyond my ability. It would be fine that you can take this. |
Hello, I also have some progress on this issue. Can I submit a PR ? |
Sure, why not? :) |
Now I found out that boost::spirit::x3 works well with std::optional (and has only minor modifications needed for working). However is it intentional that one implements a whole CSV parser instead of linking against something like libcsv3 ? |
Description
We migrated to C++17 and can start using std::optional from standard library instead of boost::optional.
The main problem here is Boost.Spirit library which doesn’t support std::optional(see #6429 (comment)).
The text was updated successfully, but these errors were encountered: