Assertion makes osrm-extract fail

[warrenwyf]

I encountered an interruption while executing the osrm-extract command while using Armenia's OSM data:

[assert][0x7000029eb000] /Users/runner/work/osrm-backend/osrm-backend/src/guidance/turn_lane_matcher.cpp:181
in: bool osrm::guidance::lanes::canMatchTrivially(const osrm::guidance::Intersection &, const osrm::guidance::lanes::LaneDataVector &): lane_data[lane].from != INVALID_LANEID
libc++abi: terminating
[1]    87885 abort      node_modules/osrm/lib/binding/osrm-extract  -p

The test data can be downloaded from http://download.geofabrik.de/asia/armenia-latest.osm.pbf

It looks like there may be errors in the data, but because of the assertion, osrm-extract doesn't ignore the errors and interrupts the execution.

[SiarheiFedartsou]

Do you build OSRM manually? We probably should have disabled asserts in Release mode 🤔

[SiarheiFedartsou]

Do you build OSRM manually? We probably should have disabled asserts in Release mode 🤔

I can reproduce only if I explicitly build OSRM like:

cmake -DENABLE_ASSERTIONS=ON .. && make -j8

[SiarheiFedartsou]

I localized the issue to this function call(after it one of TurnLaneData.from starts to be equal 255)

osrm-backend/src/guidance/turn_lane_handler.cpp

Line 327 in 41dda32

lane_data = partitionLaneData(node_based_graph.GetTarget(via_edge),

We explicitly set it to 255 (i.e. what causes assert to fire) here

osrm-backend/src/guidance/turn_lane_handler.cpp

Line 683 in 41dda32

TurnLaneData data = {TurnLaneType::straight, 255, 0};

and this augmentEntry function is expected to set this 255 to something else, but it doesn’t happen

osrm-backend/src/guidance/turn_lane_handler.cpp

Line 684 in 41dda32

augmentEntry(data);

Link to current version of armenia-latest.osm.pbf with which problem is reproducible https://drive.google.com/file/d/116GlPrZOWSFYTMjcB9BnsH31OdGg047H/view?usp=sharing

[warrenwyf]

Do you build OSRM manually? We probably should have disabled asserts in Release mode 🤔

No, I used the prebuilt binary from node-osrm:

https://github.com/Project-OSRM/osrm-backend/releases/download/v5.26.0/node_osrm-v5.26.0-node-v93-darwin-x64-Release.tar.gz

[mjjbell]

OS X release builds have assertions enabled:

osrm-backend/.github/workflows/osrm-backend.yml

Line 276 in 660cea8

ENABLE_ASSERTIONS: ON

It's probably a historical artifact that can be removed.

[mjjbell]

Actually, I'm also getting assertions on the Linux release build too. Now I am confused.

[warrenwyf]

Actually, I'm also getting assertions on the Linux release build too. Now I am confused.

Yes, but the executable files in the docker image seems to be fine

[mjjbell]

This is the problematic intersection: https://www.openstreetmap.org/#map=19/40.17416/44.50071

It includes a road whose only possible turn has a restriction applied: https://www.openstreetmap.org/relation/14065440

Therefore

• This intersection could probably do with some remodeling in OSM.
• OSRM intersection logic should be made robust to these types of mistakes.