Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.27 Release? #6325

Closed
7 tasks done
mjjbell opened this issue Aug 23, 2022 · 8 comments · Fixed by #6392
Closed
7 tasks done

5.27 Release? #6325

mjjbell opened this issue Aug 23, 2022 · 8 comments · Fixed by #6392

Comments

@mjjbell
Copy link
Member

mjjbell commented Aug 23, 2022

Given the recent activity with a number of fixes/improvements hitting master, it might be worth making a new release.

Here are some additional changes that I think should also be included:

Any other suggestions/thoughts?

@SiarheiFedartsou
Copy link
Member

Publish Windows Node builds?

It effectively means configuring build with ENABLE_NODE_BINDINGS=ON on Windows and packaging resulting module on releases?

@SiarheiFedartsou
Copy link
Member

@mjjbell
Btw do you have access to Docker Hub? I am not sure how our release process is configured, but would be great to push it there too(#6231)

@mjjbell
Copy link
Member Author

mjjbell commented Aug 23, 2022

It effectively means configuring build with ENABLE_NODE_BINDINGS=ON on Windows and packaging resulting module on releases?

Yes, hopefully we can just reuse the Node package/publish step

Btw do you have access to Docker Hub? I am not sure how our release process is configured, but would be great to push it there too(#6231)

No, we can no longer publish to Docker Hub due to a change in the TOS (hence the missing version). We've switched to using Github Packages container registry (#6138), so it will publish here in the next release. That's something else that we will need to update in the docs.

@SiarheiFedartsou
Copy link
Member

Btw I would also think about publishing Node module for Apple Silicon Macs.

@mjjbell
Copy link
Member Author

mjjbell commented Aug 24, 2022

It's not possible yet with Github hosted runners: actions/runner-images#2187

@SiarheiFedartsou
Copy link
Member

SiarheiFedartsou commented Aug 24, 2022

It's not possible yet with Github hosted runners: actions/runner-images#2187

AFAIR we can cross-compile for M1 on old Macs. I'll try to experiment with it at some day.

@SiarheiFedartsou
Copy link
Member

It's not possible yet with Github hosted runners: actions/runner-images#2187

AFAIR we can cross-compile for M1 on old Macs. I'll try to experiment with it at some day.

Well, it is possible: #6360

Just need to clean it up and figure out how to properly build release package.

@mjjbell
Copy link
Member Author

mjjbell commented Oct 6, 2022

Release candidate is out. Looks like all the new deployment infrastructure is working 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants