Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward/backward settings #569

Closed
emiltin opened this issue Jan 19, 2013 · 9 comments
Closed

forward/backward settings #569

emiltin opened this issue Jan 19, 2013 · 9 comments

Comments

@emiltin
Copy link
Contributor

emiltin commented Jan 19, 2013

ability to set speed and other settings differently for the forward/backward direction.

a specific use is pushing bikes against oneways:
#78

references:
724e96f#commitcomment-2460689

@emiltin
Copy link
Contributor Author

emiltin commented Jan 19, 2013

i pushed updated tests to the feature/opposite_direction branch, and updated the testbot profile, but there seems to be a few problems, so i could not make tests pass. there also seems to be some regresssion on other tests, like "Scenario: Routing on a oneway roundabout # features/testbot/basic.feature:237"

@emiltin
Copy link
Contributor Author

emiltin commented Jan 19, 2013

handling maxspeed:backwards seems somewhat akward, because of they way the backward speed defaults to way.speed if you don't set it.

now that way.speed and way.backward_speed is set separately it seems like way.direction could be eliminated?

we might need to be able to set the mode for each direction, for handling pushing of bikes against oneways.

@emiltin
Copy link
Contributor Author

emiltin commented Jan 19, 2013

would be easier to store (when needed) two plain ways instead of one with backward settings?

@emiltin
Copy link
Contributor Author

emiltin commented Jan 19, 2013

when handling impedance (weight) in lua scripts, this could also be different in the forw/back direction.

@DennisOSRM
Copy link
Collaborator

We should have such discussions on the mailing list. The issues get unreadable this way.

@lonvia
Copy link
Contributor

lonvia commented Mar 3, 2013

maxspeed:forward and maxspeed:backward currently use a simple 'tonumber' conversion in the lua scripts. Wouldn't it be better to use parseMaxspeed()?

DennisOSRM pushed a commit that referenced this issue Mar 3, 2013
@karme
Copy link

karme commented Mar 6, 2013

i think there is a bug regarding the backward direction (backward_speed might be overwritten by accident)

not a direct fix / but something more like:
https://github.com/karme/Project-OSRM/blob/7b203673d768bc40bd837269185855a888c3577f/profiles/bicycle.lua
might help

@karme
Copy link

karme commented Mar 6, 2013

Emil Tin [email protected] writes:

handling maxspeed:backwards seems somewhat akward, because of they way
the backward speed defaults to way.speed if you don't set it.

now that way.speed and way.backward_speed is set separately it seems
like way.direction could be eliminated?

+1 for that one

but maybe we really should take that to the mailing list?

DennisOSRM added a commit that referenced this issue Aug 21, 2014
@DennisOSRM
Copy link
Collaborator

@emiltin can we close here?

@emiltin emiltin closed this as completed Aug 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants