Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant bool member for annotations param in RouteParameters #3644

Open
karenzshea opened this issue Feb 2, 2017 · 1 comment
Open

Remove redundant bool member for annotations param in RouteParameters #3644

karenzshea opened this issue Feb 2, 2017 · 1 comment
Labels
Bug Report
Milestone
6.0

Comments

@karenzshea
Copy link
Contributor

Given the work in #3628 which makes the annotations parameter for route and matching services accept an enum of individual values, including All and None, the boolean based annotations parameter can be removed from the interface. Needs to happen in v6 though because it is breaking.
@karenzshea karenzshea added this to the 6.0 milestone Feb 2, 2017
@karenzshea karenzshea mentioned this issue Feb 2, 2017
Merged
6 tasks
@daniel-j-h
Copy link
Member

And we should think about encapsulation. At least for our public API.
Otherwise we will hit this in the future again.

@daniel-j-h daniel-j-h mentioned this issue Feb 10, 2017
Closed
This was referenced Feb 13, 2017
Merged
Closed
@mjjbell mjjbell mentioned this issue Oct 18, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report
Projects
None yet
Milestone
6.0
Development

No branches or pull requests
2 participants
@daniel-j-h @karenzshea