Refactor annotations paramater

[chaupow]

Crossposting from Project-OSRM/node-osrm#297:

tl;dr: node-osrm doesn't pass all tests anymore and its probably due to a bug in #3628

https://travis-ci.org/Project-OSRM/node-osrm/builds

tests are failing due to response not having annotations even though the request is set to annotations=true

this is a blocker for 5.6

/cc @danpat @TheMarex

[chaupow]

In oder to implement #3563
and to not add a breaking API change, we currently have two parameter member variables:

bool annotations
AnnotationsType annotations_type

this makes node-osrm have to handle two parameters. it should be made such that there's only one parameter:

AnnotationsType annotations

while still making sure annotations=true|false doesnt fail.

[daniel-j-h]

@chaupow this is already ticketed for v6 in #3644.

Until then, node-osrm handles Javascript. Therefore for node-osrm you can handle

annotations=true

keeping the old API and at the same time support

annotations='speed'

and support the new API in Javascript.

[chaupow]

@chaupow this is already ticketed for v6 in #3644.

awesome. missed this. so this can be closed as the bug is fixable in node-osrmonly.