Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect exit number in roundabouts #1025

Closed
wpetter opened this issue May 20, 2014 · 3 comments
Closed

Incorrect exit number in roundabouts #1025

wpetter opened this issue May 20, 2014 · 3 comments

Comments

@wpetter
Copy link

wpetter commented May 20, 2014

You get an incorrect exit number for roundabouts with one-way connections. Entrances are also added to the exit count.

In this example you should exit at second exit but the instructions say third exit
http://osrm.at/7ub
@emiltin
Copy link
Contributor

emiltin commented May 20, 2014

Added cucumber tests (marked with @bug) with bddad0c.

@emiltin
Copy link
Contributor

emiltin commented May 20, 2014

Is OSRM ever omitting "leave roundabout" (code 12) and "stay on roundabout" (code 13) instructions?

DennisOSRM added a commit that referenced this issue May 20, 2014
@DennisOSRM
fix issue #1025:
9a2d701 
- add function to count directed outgoing edges
- generate correct instruction for staying on a roundabout
- move test from @bug namespace to the general one
@DennisOSRM
Copy link
Collaborator

@wpetter thanks for reporting. this is now fixed in 9a2d701 and will move into upstream this week

@emiltin thanks for adding the test so quickly. helped a lot getting the bug squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emiltin @DennisOSRM @wpetter