Skip to content

Commit

Permalink
test showing bug related to via points. see #1034
Browse files Browse the repository at this point in the history
  • Loading branch information
@emiltin
emiltin committed May 23, 2014
1 parent 5057ae9 commit 06f3375
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions features/testbot/via.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,24 @@ Feature: Via points
| waypoints | route |
| a,c,f | ab,bcd,de,efg |
| a,c,f,h | ab,bcd,de,efg,gh |

@bug
Scenario: Via points on ring of oneways
Given the node map
| a | 1 | 2 | 3 | b |
| d | | | | c |

And the ways
| nodes | oneway |
| ab | yes |
| bc | yes |
| cd | yes |
| da | yes |

When I route I should get
| waypoints | route | distance | turns |
| 1,3 | ab | 200m +-1 | head,destination |
| 3,1 | ab,bc,cd,da,ab | 800m +-1 | head,right,right,right,right,destination |
| 1,2,3 | ab | 200m +-1 | head,destination |
| 1,3,2 | ab,bc,cd,da,ab | 1100m +- | head,right,right,right,right,destination |
| 3,2,1 | ab,bc,cd,da,ab,bc,cd,da,ab | 1900m +- | head,right,right,right,right,right,right,right,destination |

5 comments on commit 06f3375

@DennisOSRM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do single rings in tests. These tend to trigger edge cases that do not actually test the issue at hand.

@emiltin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so just add a leg?

@DennisOSRM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right.

@emiltin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thus updated. in this case it didn't cause a change in the routing results.

@DennisOSRM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

Please sign in to comment.