Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

Remove circleci support #303

Closed
wants to merge 1 commit into from
Closed

Remove circleci support #303

wants to merge 1 commit into from

Conversation

springmeyer
Copy link

@springmeyer springmeyer commented Mar 9, 2017

We've been continuing to depend on travis for testing and building on both linux and osx. In #221 we looked at using circle for OS X (circle has the limitation of only being able to build for one platform per project), but never moved on that per #221 (comment).

However now I think we should disable circle support completely by:

The reason is that circle is currently failing due to xcode version issues:

# constructor: uses defaults with no parameter
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /Users/distiller/node-osrm/lib/binding/node-osrm.node
  Expected in: flat namespace

These are probably the same as Project-OSRM/osrm-backend#3297 and only manifest with specific xcode combinations which are non-critical to fix and blocked on a boost bug. So, while fixable I think this is such a low priority we should disable circle to reduce distracting build failures we don't have the focus to fix.

@danpat
Copy link
Member

danpat commented Mar 10, 2017

LGTM - given Project-OSRM/osrm-backend#3768, we should do the minimum here though.

@TheMarex
Copy link
Member

Obsolete with 5.7

@TheMarex TheMarex closed this Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants