This repository has been archived by the owner on Jun 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been continuing to depend on travis for testing and building on both linux and osx. In #221 we looked at using circle for OS X (circle has the limitation of only being able to build for one platform per project), but never moved on that per #221 (comment).
However now I think we should disable circle support completely by:
The reason is that circle is currently failing due to xcode version issues:
These are probably the same as Project-OSRM/osrm-backend#3297 and only manifest with specific xcode combinations which are non-critical to fix and blocked on a boost bug. So, while fixable I think this is such a low priority we should disable circle to reduce distracting build failures we don't have the focus to fix.