Fix set_timesteps #163
Merged
Fix set_timesteps #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger than num_train_timesteps Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
ericspod
approved these changes
Jan 5, 2023
| step_ratio = self.num_train_timesteps // self.num_inference_steps | ||
| # creates integer timesteps by multiplying by ratio | ||
| # casting to int to avoid issues when num_inference_step is power of 3 | ||
| timesteps = (np.arange(0, num_inference_steps) * step_ratio).round()[::-1].copy().astype(np.int64) |
There was a problem hiding this comment.
I don't think copy is needed here, the array is fresh and round should also return a fresh one.
There was a problem hiding this comment.
Good point, again it was from the base implementation (huggingface/diffusers#724), but I think here it is safe to remove (for example PNDM already does not use it)
Thanks, Eric! The "power of 3" is one point that we found in the reference code and we kept to avoid problems (discussed here huggingface/diffusers#466) |
Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
Warvito
deleted the
162-wrong-number-of-timesteps-when-num_inference_steps-is-not-a-divisor-of-num_train_timesteps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #162
Signed-off-by: Walter Hugo Lopez Pinaya [email protected]