Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RadImageNet to Perceptual Loss #153

Merged
merged 4 commits into from
Jan 8, 2023

Conversation

Warvito
Copy link
Collaborator

@Warvito Warvito commented Dec 21, 2022

Implements #26

Signed-off-by: Walter Hugo Lopez Pinaya [email protected]

Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
@Warvito Warvito linked an issue Dec 21, 2022 that may be closed by this pull request
Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
@Warvito Warvito marked this pull request as ready for review December 22, 2022 13:54
@Warvito
Copy link
Collaborator Author

Warvito commented Dec 22, 2022

I am developing the other entrypoints and converting the networks from https://github.com/BMEII-AI/RadImageNet to pytorch (working with Zelong Liu for this). The plan is to add support to at least inceptionV3 and mobilenet.

Signed-off-by: Walter Hugo Lopez Pinaya <[email protected]>
Copy link
Contributor

@danieltudosiu danieltudosiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I would approve the pull request. But there are some quality of life improvements.

generative/losses/perceptual.py Show resolved Hide resolved
generative/losses/perceptual.py Show resolved Hide resolved
generative/losses/perceptual.py Show resolved Hide resolved
@Warvito Warvito merged commit e9597bb into main Jan 8, 2023
@Warvito Warvito deleted the 26-add-radimagenet-option-to-perceptual-loss branch January 8, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RadImageNet option to Perceptual loss
2 participants