トーク選択画面を追加 #28
Open
トーク選択画面を追加 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojun9
approved these changes
Jul 16, 2020
| } | ||
|
|
||
| func transitionToChatsViewController(selectedRoom room: Room) { | ||
| //TODO:- 画面遷移時に加えて値の引き渡しをする |
There was a problem hiding this comment.
渡す値は，ルームの名前とルームIDだと思うのですが，
その場合はRoomモデルにidを追加する必要がありそうですね。
There was a problem hiding this comment.
あ、確かにそうですね、、、！！
このPRでChat側に渡しておいていいですか？？
There was a problem hiding this comment.
遅くなりましたが、更新しました！！
geekshu625
force-pushed
the
feature/6
branch
2 times, most recently
from
ebb7fd7 to
1761114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
レビュー観点
とりあえず、未確定の部分や画像周りの部分はあとでやります。
レビューレベル
Lv0: まったく見ないでAcceptするLv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証してAcceptするLv3: 実際に環境で動作確認したうえでAcceptするスクリーンショット