Feature/15 #22
Merged
Feature/15 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojun9
reviewed
Jul 11, 2020
| self?.presenter.onError(error: err) | ||
| } | ||
|
|
||
| if let uid = result?.user.uid { |
There was a problem hiding this comment.
if letでの処理ですが，else以降の処理がないので個人的には
guard let uid = result?.user.uid else {
self?.presenter.onError()
return
}
let userReference = Firestore.firestore().collection("message").document("v1").collection("users").document(uid)
とした方がネストが1つ少なくなってエラー処理もで切ると思うのですがどうでしょうか？
There was a problem hiding this comment.
確かにそちらの方が綺麗ですね、修正します！
| if let error = error { | ||
| Auth.auth().signIn(withEmail: email, password: password) { [weak self] (result, error) in | ||
| if let err = error { | ||
| self?.presenter.onError(error: err) |
There was a problem hiding this comment.
self?.presenter.onError(error: err)の後にreturnしてあげないと処理が以降に繋がってしまうのではないでしょうか？
There was a problem hiding this comment.
忘れてました、こちらも修正します！
|
修正しました！ |
ojun9
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
レビュー観点
レビューレベル
Lv0: まったく見ないでAcceptするLv1: ぱっとみて違和感がないかチェックしてAcceptするLv3: 実際に環境で動作確認したうえでAcceptする備考