Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api client generation #6

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

Dennis-Rosenbaum
Copy link
Member

Generate API by the swagger.json.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-moss-0dcca7e03-6.westeurope.5.azurestaticapps.net

name: "api.ts",
output: path.resolve(process.cwd(), "./src/api/backend"),
url: "https://dynamic-qrs.azurewebsites.net/api/swagger.json",
// 'axios' or or 'fetch'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment can be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Comment on lines +26 to +36
/**
* No description
*
* @tags qr-code
* @name QrCodeTargetPut
* @summary Update a certain qr code target.
* @request PUT:/qr-codes/{id}/target
* @response `200` `QrCodeTargetPutResponse` Update a certain qr code target
* @response `400` `void` Request couldn't be parsed. Or missing organization identifier header. Or missing customer identifier header.
* @response `502` `void` No qr code target found with the given identifier.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify things comments could be nice. However, a description is missing from the comments blocks, yet the properties are described. I would propose to add a description to complete the comment block :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in /api/backend are all generated. Therefore we can't (and shouldn't) change them.
If you want to add some description, we need to add the description in the backend API documentation and regenerate these classes by running npm run generate-api-client

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://calm-moss-0dcca7e03-6.westeurope.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants