-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show edit window and buttons below changes when using PageForms #406
base: master
Are you sure you want to change the base?
Conversation
It fails the PHPUnit tests, but works. What must be done to fix the tests? |
Any thoughts, @malberts ? |
Can you rebase this on the latest master? I don't remember if the tests failed because of the code change, or because of some other unrelated CI issue. However, I still need to look at this. Besides some code style issues (indents), I would like to investigate if this change can happen in a way that does not repeat that same code in all the components. |
As far as I understood it, it was code change, because as far as I remembered it, the error messages were about the ‘getHtml’ function in the PHPUnit tests. I don't know if all these changes are necessary, because after yet another round of tests, I just changed it everywhere. |
I 'm testing the changes now on a chameleon version 4.4.1. No problems yet. https://nl.scoutwiki.org/ |
@malberts have you had time to look at it? Before the checks disapear again. |
Should solve #319.
@ckapop found the issue that was causing this error and a solution. The changes were made suitable for and tested on Chameleon 4.3.0 by @WouterRademaker.