Allow spaces in jobname #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kernald
reviewed
Aug 18, 2022
| @@ -66,7 +66,7 @@ | |||
| return_code = subprocess.call( | |||
| args=[ | |||
| latexrun_file, | |||
| "--latex-args=-shell-escape -jobname=" + job_name, | |||
| "--latex-args=-shell-escape -jobname='" + job_name.replace("'", "'\\''") + "'", | |||
There was a problem hiding this comment.
Should we use something a bit more robust here, like shlex.quote() or pipes.quote() if we have to support Python 2 (I'm really not familiar with Python and don't know how to tell from a quick glance whether this is Python 2 or 3...)
There was a problem hiding this comment.
Unless I'm missing something, we're using Python 3 (https://bazel.build/reference/be/python#py_binary.python_version). shlex.quote() would likely be the best way forward here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to latexrun inserts the job name, but doesn't do any shell escaping while passing it. Wrapping this input in single quotes keeps it from being split or otherwise processed by the next shell pass.