Skip to content

Commit

Permalink
Add comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mUusitalo committed Oct 19, 2024
1 parent 4e8d1da commit dc6244d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,10 @@ jobs:
context: .
push: true
tags: ${{ secrets.REGISTRY_LOGIN_SERVER }}/vaalikoppi/vaalikoppi:${{ github.sha }}
cache-from: type=gha
cache-to: type=gha,mode=max
# There is intentionally no scope on the cache due to github's cache access restrictions.
# Both the release and debug file will now be stored in the same location.
cache-from: type=gha
cache-to: type=gha,mode=max
build-args: |
"DATABASE_URL=postgres://vaalikoppi:ci-password@localhost:5432/vaalikoppi"
allow: |
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,13 @@ jobs:
push: false
load: true
tags: vaalikoppi/e2e:${{ github.sha }}
cache-from: type=gha
cache-to: type=gha,mode=max
# There is intentionally no scope on the cache due to github's cache access restrictions.
# Both the release and debug file will now be stored in the same location.
# Might be worth it to just build the release version even when testing -
# the main build would then be very fast and you'd save the costs of loading twice the amount of cache
# (both debug and release) even when you only need one of them
cache-from: type=gha
cache-to: type=gha,mode=max
build-args: |
"DATABASE_URL=postgres://vaalikoppi:ci-password@localhost:5432/vaalikoppi"
"DEBUG=true"
Expand Down

0 comments on commit dc6244d

Please sign in to comment.