Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix most warnings, add several TODO comments #142

Merged
merged 1 commit into from
Nov 19, 2022
Merged

fix most warnings, add several TODO comments #142

merged 1 commit into from
Nov 19, 2022

Conversation

shapr
Copy link
Collaborator

@shapr shapr commented Nov 18, 2022

  • code compiles without errors (but does have a warning)
  • tests pass

@exarkun exarkun mentioned this pull request Nov 18, 2022
Open
@hacklschorsch
Copy link
Member

🤙 really nice!

@exarkun exarkun merged commit 5254d7f into main Nov 19, 2022
@exarkun exarkun deleted the hlint-pass branch November 19, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shapr @hacklschorsch @exarkun