Sync world #40
Merged
Sync world #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also complete the API and cleanup
rom1504
commented
Jul 13, 2020
| this.async = world | ||
| } | ||
|
|
||
| initialize (iniFunc, length, width, height = 256, iniPos = new Vec3(0, 0, 0)) { |
There was a problem hiding this comment.
I kept a duplicated of this because actually this is quite different : this is using the sync primitive and might fail (do nothing) if columns are not loaded.
Also it might be much faster than the async version
|
checks pass in flying squid using this PrismarineJS/flying-squid#415 |
|
going to try using it in mineflayer |
|
PrismarineJS/mineflayer#1145 to try using it in mineflayer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new one because I don't have push rights to #39
I tried to put it common the methods that could be, but still keeping a mirror in some case in sync for convenience
I explained the logic in the README
I think this is not fully satisfying but it's a good start.
Can you please review @Karang ?