Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide protocol js into several datatypes files #161

Merged
merged 12 commits into from
May 14, 2015

Conversation

rom1504
Copy link
Member

@rom1504 rom1504 commented May 13, 2015

Also reorganize some stuff in protocol.js.
Not quite ready to merge yet.

Left to be done :

  • see if parse* functions and stuff in client.js can be put in a stream.js
  • better encapsulation of packets indexes
  • more comparing on differences with Protocols

@rom1504
Copy link
Member Author

rom1504 commented May 14, 2015

Actually I think the rest of the refactoring can be done in an other PR.
Ready to merge.

roblabla added a commit that referenced this pull request May 14, 2015
Divide protocol js into several datatypes files
@roblabla roblabla merged commit ec0f686 into PrismarineJS:master May 14, 2015
@rom1504 rom1504 deleted the divide_protocol_js branch May 14, 2015 17:32
@rom1504 rom1504 mentioned this pull request May 14, 2015
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants