fixed incorrect materials.json in 1.20.5 and 1.21.1 #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GroobleDierne thoughts? |
The current work looks good however, it is planned that @Madlykeanu also fixes the generator for 1.21.3 and updates 1.21.3's materials.json. He said he was taking a little break so I think we can wait before merging this and merge it anyway if he doesn't start working on it again. |
|
Ah yea i haven't had much time lately, im not sure when ill be able to work on it again. If this is merged now when I fix it for 1.21.3 I can just open a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was causing stone and some other blocks to take much longer to mine then they should. this will close PrismarineJS/prismarine-block#102 :D