Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert editbook features to single feature enum #938

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions data/pc/common/features.json
Original file line number Diff line number Diff line change
Expand Up @@ -231,21 +231,6 @@
"latest"
]
},
{
"name": "editBookIsPluginChannel",
"description": "book editing is handled through plugin channels",
"versions": ["1.8", "1.12.2"]
},
{
"name": "hasEditBookPacket",
"description": "book editing is handled through a packet with the updated book item",
"versions": ["1.13", "latest"]
},
{
"name": "editBookPacketUsesNbt",
"description": "edit_book packet sends a new book item (with its NBT containing page data) to server",
"versions": ["1.13", "1.17.1"]
},
{
"name": "clientUpdateBookIdWhenSign",
"description": "when sending MC|BSign, item type should be written_book",
Expand Down Expand Up @@ -595,6 +580,32 @@
"description": "added shulker boxes to the game",
"versions": ["1.13", "latest"]
},
{
"name": "editBookFunctionVersion",
"description": "version of the edit_book function",
"values": [
{
"value": "0",
"description": "book editing is handled through plugin channels",
"versions": ["1.8", "1.12.2"]
},
{
"value": "1",
"description": "book editing is handled through it's own packet now",
"versions": ["1.13", "1.17"]
},
{
"value": "2",
"description": "book edit packet's fields have changed",
"versions": ["1.18", "1.21"]
},
{
"value": "3",
"description": "book edit packet's fields have changed again",
"versions": ["1.21.1", "latest"]
}
]
},
{
"name": "metadataIxOfItem",
"description": "item.metadata[this_ix] will be the item that was dropped on the ground",
Expand Down
Loading