1.20.5 Protocol #884
Closed
1.20.5 Protocol #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are several things missing. For example any places where item stacks are written now have optional slots (like ServerboundSetCreativeModeSlotPacket, ServerboundContainerClickPacket, etc). Also ServerboundContainerButtonClickPacket now uses varints over i8's. There are likely more. |
extremeheat
reviewed
Jun 22, 2024
data/pc/1.20.5/protocol.json
Outdated
Comment on lines
3621
to
3631
| "name": "x", | ||
| "type": "i8" | ||
| }, | ||
| { | ||
| "name": "z", | ||
| "type": "i8" | ||
| }, | ||
| { | ||
| "name": "direction", | ||
| "type": "u8" | ||
| }, |
There was a problem hiding this comment.
these might be double, double, float now
https://github.com/extremeheat/extracted_minecraft_data/blame/client1.20.5/client/net/minecraft/world/item/component/MapDecorations.java#L27-L30
| "packet_world_particles": [ | ||
| "container", | ||
| [ | ||
| { |
There was a problem hiding this comment.
|
Also need item fixed
|
extremeheat
reviewed
Jun 23, 2024
Comment on lines
+159
to
+167
| "max_stack_size_component": [ | ||
| "container", | ||
| [ | ||
| { | ||
| "name": "maxStackSize", | ||
| "type": "varint" | ||
| } | ||
| ] | ||
| ], |
There was a problem hiding this comment.
is there a reason these are not inlined?
|
continuing at #898 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update protocol to 1.20.5 as specified in https://wiki.vg/index.php?title=Pre-release_protocol&oldid=19287