Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bedrock 1.19.80-1.20.71 blocks data #864

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

FreezeEngine
Copy link
Contributor

  • 1.20.50-1.20.71 should be close to perfect
  • 1.19.80-1.20.40 blockStates and blocks tested but other data not sure

Data from extractor + used "checkout" to rollback some repos to generate older data

@FreezeEngine
Copy link
Contributor Author

Some new data here, let me know if there is anything wrong @extremeheat

@extremeheat extremeheat changed the title 1.19.80-1.20.71 blocks data Bedrock 1.19.80-1.20.71 blocks data Apr 1, 2024
@extremeheat
Copy link
Member

Would be great if there was a way to test this data

@FreezeEngine
Copy link
Contributor Author

Would be great if there was a way to test this data

Block states were generated from geyser palletes, I have ran a small test on first state of almost each block, I think I can publish it soon (basically takes block names from block enum in avaliable commands packet, runs /setblock foraech of them and awaits for block to change -> gets block name from blocksByStateId and compares)

Also might be able to implement it as a test here

.60 and .70 data I tested with my bot by looking if it decoded pallete correctly and if it fell through the world, collisions were always strange on some blocks, seems like state to correct bounding box is not working propperly (mostly feels like every state has only one collision or is rotated wrongly except for default state)

@extremeheat
Copy link
Member

Yes, right now there is no way to validate this data, but there should be. The server sends a block palette checksum so we could check against that in the future. But ideally this is all automated without needing manual work.

@extremeheat
Copy link
Member

In the meantime though I'll merge to not create a PR backlog, we can figure out the validation later

@extremeheat extremeheat merged commit e34bced into PrismarineJS:master Apr 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants