Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Data Version - Doc update #835

Merged
merged 11 commits into from
Jan 25, 2024
Merged

Conversation

wgaylord
Copy link
Contributor

@wgaylord wgaylord commented Jan 14, 2024

I still need to add a doc about the soon to be added sounds.json file. But I think this should be good or at least a bit better.

Also want to expand out what tests to run and that sort of thing before merging this, in addition, I need to document the loginPacket and how to get it and also how to add the new version to all the files that need it defined.

I plan on adding all the info in the next few days.

…enerator-server

Update the auto list to reflect what  minecraft-data-generator-server generates and also about what issues you may have to fix in its generated files.

Also noted that `blockLoot.json` and `entityLoot.json` has no currently working extractor.
@wgaylord
Copy link
Contributor Author

I have added the loginPacket and soon to be added sounds.json. Also added details about the other two files that need to be updated.

@wgaylord wgaylord changed the title WIP - Doc update Add New Data Version - Doc update Jan 16, 2024
| enchantments.json | Yes | Use [minecraft-data-generator-server][2] |
| language.json | Yes | Use [minecraft-data-generator-server][2] |
| particles.json | Yes | Use [minecraft-data-generator-server][2] |
| blockLoot.json | No | Use [minecraft-jar-extractor][7] | Currently no extractor seems to works for this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you say both that people should use Minecraft jar extractor and that there is no extractor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I link it since its the last know working extractor. I should probably mention that some where.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the mention of it. Since it doesn't work.

| particles.json | Yes | Use [Burger][1], then use [burger-extractor][2] |
| blockLoot.json | Yes | Use [minecraft-jar-extractor][10] |
| entityLoot.json | Yes | Use [minecraft-jar-extractor][10] |
| mapIcons.json | No | Icons can be found in the Minecraft jar file where they are added as a single sprite. The file location is `/assets/minecraft/textures/map/map_icons.png`. Alternatively you might be able to look up the icons from the following page on the [Minecraft wiki][15] or from [wiki.vg][16]. | [minecraft-data pr mapIcons][14] |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the file path for this, is it incorrect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a correct file path but not useful. Since it doesn't label the icons at all, and doesn't provide the information needed to fill out the mapIcons.json file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgaylord
Copy link
Contributor Author

Any further comments?

| enchantments.json | Yes | Use [minecraft-data-generator-server][2] |
| language.json | Yes | Use [minecraft-data-generator-server][2] |
| particles.json | Yes | Use [minecraft-data-generator-server][2] |
| blockLoot.json | No | Currently no extractor seems to works for this |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minecraft-jar-extractor should be mentioned even if it needs updates ; until we have something better

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just did some testing, seems the extractor will work for 1.20.3 but not 1.20.4, 1.20.2 or 1.20 it self which makes no sense at all (Throwing timeouts errors on getting the jars or data from mojang). So I will update this to say to use it but that it may have require fixing per versions.

@rom1504 rom1504 merged commit c1b5113 into PrismarineJS:master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants