node 18 #709
Merged
node 18 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
idk where is that require-self mention |
|
it's from node-minecraft-data https://github.com/PrismarineJS/node-minecraft-data/blob/master/package.json#LL13C17-L13C80 None of the prepare scripts seem to need it so it can probably be removed, but the problem maybe it's not installing the devDeps for some reason |
|
we can simply replace require self by self dep |
|
I don't understand why it fails with |
|
so error here is still tried various things but nothing helps any more idea here @extremeheat ? |
|
Should be fixed, not sure what flow was going on previously |
|
Thanks |
AlexProgrammerDE
pushed a commit
to AlexProgrammerDE/minecraft-data
that referenced
this pull request
Jan 1, 2024
* node 18 * Update bedrock-ci.yml * Update update-helper.yml * Update ci.yml * Update bedrock-ci.yml * Update bedrock-ci.yml * Update bedrock-ci.yml * Update bedrock-ci.yml * Update bedrock-ci.yml order * Update bedrock-ci.yml --------- Co-authored-by: extremeheat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.