-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advancements data #584
Conversation
I kinda wanna become a contributor here, Any reason why you made a new pr? |
Also, the schema is not under changed files |
I'm aware, I still need to do that |
No reason just seeing as it is generated completely differently I thought it would be better to have a separate PR. |
So I could also just add that updated file to my PR? |
|
I mean you can do that I'm just going to add all data in this PR |
good point, I think those are more accurate, I'll change that |
Alright I've got to go to work, I'll be back in ~3 hours and will make those changes, update the data (and also fix the achievements as I just realized I generated 1.18 achievements instead of 1.19) |
I updated my pull request #583 accordingly |
Okay thank you! Just trying to improve my github stats 😅 Do you mind sending or linking me your conversion tool so i can take a look at it? |
You can make a PR/discuss on his branch, it doesn't make sense to have two PRs when only one can be merged |
there is no point having multiple PRs for it, I think just keeping this one open would be better (/nm, not mad). I'm going to completely rework the format and add information from the default texture pack so it is more complete. I'll share the tool once I've finished it |
changed to a new format, will discuss in Discord about possibly more additions |
This PR adds advancement data (automatically generated, based off of #583).
Todo:
– Update README.md
– Add data for other versions