Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity_metadata.json for 1.8 #132

Closed
wants to merge 0 commits into from
Closed

Conversation

hansihe
Copy link
Contributor

@hansihe hansihe commented Apr 5, 2016

This is still largely unverified/untested. It would be nice if someone could look it over.

The format is mostly made up. Please comment if you have any improvements on it.

@Gjum
Copy link
Member

Gjum commented Apr 5, 2016

There was some talk about the format in #72 already, the major difference being that the fields are objects instead of arrays, like this:

"fields": [
 { 
   "index":17,
   "type":"int",
   "meaning":"Shaking Power"
  }
]

I personally prefer objects over arrays here because of extensibility and readability.

@rom1504
Copy link
Member

rom1504 commented Apr 8, 2016

Yes I agree with @Gjum
Also the bitmasks values are missing (for example http://wiki.vg/Entities#Guardian )
It could be done with a format like

[
  {
    "bitMask":"0x02",
    "displayName":"is retracting spikes",
    "name":"isRetractingSpikes"
  }
  {
    "bitMask":"0x04",
    "displayName":"is elderly",
    "name":"isElderly"
  }
]

as a "values" property of each entity_metadata item.

But we don't have to do that for the first pass of that file.

@rom1504
Copy link
Member

rom1504 commented May 10, 2017

oh why delete this ?
well I kind of understand, it was in master branch, but could you get back the commits, put it in another branch and re-open a pr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants