-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCPE support #65
Comments
Yeah I agree , I guess we would follow the same organization than versions (so branches for now and possibly folders if we do choose to use folders in #64 ) |
It would be nice to find some good sources to build a protocol.json for mcpe.
AFAIK mcpe is now at 0.12 , so no doc seems up to date. Would it be possible to find something with wireshark ? Is it possible to run a vanilla mcpe server on PC (Linux) ? What's the best way to test something like a nmp for mcpe ? |
@rom1504 there's also PocketBurger https://github.com/PocketMine/PocketBurger |
Also see where @creeplays is taking his data from (https://github.com/mhsjlw/mcpe-server/blob/master/lib/net/protocol.js#L75) Found the source https://github.com/jhead/node-mcpe/blob/master/lib/net/Protocol.js |
http://minecraft.gamepedia.com/Pocket_Edition : ah the last version is only available in windows 10 |
@rom1504 Don't use the original source for the mcpe-server, we've updated the packet names so the old Protocol.js file is no longer usable |
What about https://github.com/PocketMine/PocketMine-MP/tree/master/src/pocketmine/network/protocol ? seems more or less up to date |
@rom1504 Looked at it a while ago, it is useless |
No, that second file give the packets id<-->name, but that's not very useful, the first link give you all the fields for each packet. |
@rom1504 Can we turn this into readable documentation? |
We can probably turn it into a protocol.json, which can then be converted automatically to a doc. edit: what we need is the protocol.json, that will allow to produce a nmp for mcpe, the documentation is useful, but only to use that nmp for mcpe. |
I guess we'll be following the same structure as currently : a new branch for each mcpe version. So that means a mcpe-0.12 branch. It's related to #64 . Continuing this comment there. |
What if this was put in another repository, like mcpe-data? |
It'd be best to keep in same repo so it works flawlessly in nmp. The two games should be close enough for the schemas not to diverge I think. What advantage would there be to a different repo? |
@roblabla I am one for keeping it in this repo. For example, if I need minecraft-data for both the games instead of grabbing 2 repositories I can just have one with all the info I need. Additionally, MCPE protocol and data is quite small at the moment but is getting bigger so it shouldn't be too bad if we keep it around |
yeah, this is minecraft-data not mcpc-data. It probably makes sense to have all the data inside this repo. It doesn't take much room anyway ;) |
some more data from @mhsjlw |
some recent work https://github.com/mhsjlw/pocket-minecraft-protocol |
to be exact, https://github.com/mhsjlw/pocket-minecraft-protocol/blob/master/data/protocol.json it is currently up-to-date with MCPE 0.14 |
okay the protocol.json is actually getting almost ready. Should there be a data/pe-0.14 ? should the pc version be prefixed by pc- ? Also, is it a good idea to put everything in that repo or should we not split it in a minecraft-data-pe repo ? (still keeping the same schema by putting the schema somewhere else for example) |
@rom1504 data/pe/ and data/pc/ seems reasonable to me. Or data/pe-0.14, but having MCPE and MCPC in separate directories would keep the namespace cleaner. |
Ok, well, it's pretty official, we've started development of numerous-alpaca and mcpe-chunk among others. MCPE data will be placed in minecraft-data. We also have 0.30c so this is a very universal minecraft-data. It just should be noted that all this MCPE data is extremely bleeding-edge and it will be updated often, especially with the upcoming encryption update. All data will be put under a pe directory. |
Also see #138 |
mcpe data is there. |
Done. The adding of other pe files can be tracked in other issues. |
* put parsePacketData in deserializer and createPacketBuffer in serializer * remove packets from the index and expose readPacket instead * load packets when needed in various files * make tests test every supported version static cross version of PrismarineJS#234, fix PrismarineJS#65, fix PrismarineJS#240
It'd be interesting to have the MCPE data available here as well. I believe the two games are close enough to actually be able to support both schema types. The protocol will probably be the one file to change the most, but I believe its schema won't have to change all that much either
The text was updated successfully, but these errors were encountered: