Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCPE support #65

Closed
roblabla opened this issue Sep 10, 2015 · 27 comments
Closed

MCPE support #65

roblabla opened this issue Sep 10, 2015 · 27 comments

Comments

@roblabla
Copy link
Member

It'd be interesting to have the MCPE data available here as well. I believe the two games are close enough to actually be able to support both schema types. The protocol will probably be the one file to change the most, but I believe its schema won't have to change all that much either

@rom1504
Copy link
Member

rom1504 commented Sep 10, 2015

Yeah I agree , I guess we would follow the same organization than versions (so branches for now and possibly folders if we do choose to use folders in #64 )

@rom1504
Copy link
Member

rom1504 commented Sep 10, 2015

It would be nice to find some good sources to build a protocol.json for mcpe.

doc version format description
wiki.vg pe doc general info and current state of the mcpe protocol doc, links to implementations
minet 0.10 markdown packets doc updated in july
dragonet 0.11 java classes : one by packet code to read/write mcpe protocol
old wiki.vg pe doc between 0.10 and 0.11 wikitext doc of the packets

AFAIK mcpe is now at 0.12 , so no doc seems up to date. Would it be possible to find something with wireshark ?

Is it possible to run a vanilla mcpe server on PC (Linux) ?

What's the best way to test something like a nmp for mcpe ?

@roblabla
Copy link
Member Author

@rom1504 there's also PocketBurger https://github.com/PocketMine/PocketBurger

@rom1504
Copy link
Member

rom1504 commented Sep 10, 2015

@rom1504
Copy link
Member

rom1504 commented Sep 10, 2015

http://minecraft.gamepedia.com/Pocket_Edition : ah the last version is only available in windows 10
Edit: actually no it's also up to date on other platforms like Android where 0.12.1 is available

@ghost
Copy link

ghost commented Sep 11, 2015

@rom1504 Don't use the original source for the mcpe-server, we've updated the packet names so the old Protocol.js file is no longer usable

@rom1504
Copy link
Member

rom1504 commented Sep 11, 2015

@ghost
Copy link

ghost commented Sep 11, 2015

@rom1504 Looked at it a while ago, it is useless

@rom1504
Copy link
Member

rom1504 commented Sep 11, 2015

No, that second file give the packets id<-->name, but that's not very useful, the first link give you all the fields for each packet.

@ghost
Copy link

ghost commented Sep 11, 2015

@rom1504 Can we turn this into readable documentation?

@rom1504
Copy link
Member

rom1504 commented Sep 11, 2015

We can probably turn it into a protocol.json, which can then be converted automatically to a doc.
It's the 0.12 branch we'd be more interested about https://github.com/PocketMine/PocketMine-MP/tree/mcpe-0.12/src/pocketmine/network/protocol

edit: what we need is the protocol.json, that will allow to produce a nmp for mcpe, the documentation is useful, but only to use that nmp for mcpe.

@rom1504
Copy link
Member

rom1504 commented Sep 21, 2015

@rom1504
Copy link
Member

rom1504 commented Sep 22, 2015

I guess we'll be following the same structure as currently : a new branch for each mcpe version.

So that means a mcpe-0.12 branch.

It's related to #64 . Continuing this comment there.

@phase
Copy link
Contributor

phase commented Oct 25, 2015

What if this was put in another repository, like mcpe-data?

@roblabla
Copy link
Member Author

It'd be best to keep in same repo so it works flawlessly in nmp. The two games should be close enough for the schemas not to diverge I think. What advantage would there be to a different repo?

@ghost
Copy link

ghost commented Oct 25, 2015

@roblabla I am one for keeping it in this repo. For example, if I need minecraft-data for both the games instead of grabbing 2 repositories I can just have one with all the info I need. Additionally, MCPE protocol and data is quite small at the moment but is getting bigger so it shouldn't be too bad if we keep it around

@rom1504
Copy link
Member

rom1504 commented Oct 25, 2015

yeah, this is minecraft-data not mcpc-data. It probably makes sense to have all the data inside this repo. It doesn't take much room anyway ;)

@rom1504
Copy link
Member

rom1504 commented Feb 12, 2016

some more data from @mhsjlw
https://gist.github.com/mhsjlw/447233933f3a68a10cea

@rom1504
Copy link
Member

rom1504 commented Mar 4, 2016

@ghost
Copy link

ghost commented Mar 4, 2016

to be exact, https://github.com/mhsjlw/pocket-minecraft-protocol/blob/master/data/protocol.json it is currently up-to-date with MCPE 0.14

@rom1504
Copy link
Member

rom1504 commented Mar 6, 2016

okay the protocol.json is actually getting almost ready.
It will soon be time to think about moving it to mcdata.
That requires some organization thinking.

Should there be a data/pe-0.14 ? should the pc version be prefixed by pc- ?
Or should we have a data/pe/ and data/pc/ ?

Also, is it a good idea to put everything in that repo or should we not split it in a minecraft-data-pe repo ? (still keeping the same schema by putting the schema somewhere else for example)

@rom1504
Copy link
Member

rom1504 commented Mar 6, 2016

I think the data/pe/ and data/pc/ is probably the more simple option.

Any thoughts @deathcap @roblabla @mhsjlw ?

@deathcap
Copy link
Member

deathcap commented Mar 6, 2016

@rom1504 data/pe/ and data/pc/ seems reasonable to me. Or data/pe-0.14, but having MCPE and MCPC in separate directories would keep the namespace cleaner.

@ghost
Copy link

ghost commented May 23, 2016

Ok, well, it's pretty official, we've started development of numerous-alpaca and mcpe-chunk among others. MCPE data will be placed in minecraft-data. We also have 0.30c so this is a very universal minecraft-data. It just should be noted that all this MCPE data is extremely bleeding-edge and it will be updated often, especially with the upcoming encryption update. All data will be put under a pe directory.

@ghost
Copy link

ghost commented May 23, 2016

Also see #138

@rom1504
Copy link
Member

rom1504 commented May 31, 2016

mcpe data is there.
Let's just update the README with that info and then this issue can be closed.

@rom1504
Copy link
Member

rom1504 commented May 31, 2016

Done. The adding of other pe files can be tracked in other issues.

@rom1504 rom1504 closed this as completed May 31, 2016
IceTank pushed a commit to IceTank/minecraft-data that referenced this issue Mar 27, 2024
* put parsePacketData in deserializer and createPacketBuffer in serializer
* remove packets from the index and expose readPacket instead
* load packets when needed in various files
* make tests test every supported version
static cross version of PrismarineJS#234, fix PrismarineJS#65, fix PrismarineJS#240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants