-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity json file #11
Comments
Actually I don't think we need displayName and it's a bit annoying to get. |
/Darthfett/helperbot I believe would need displayName to lookup blocks and items. It would be good to provide the same API here, if any projects end up needing it for entities. For example, a bot that tells you how many entities are in range (and their names). |
Why would you need the displayName ? Isn't the name enough ? |
I'm not even sure the original proposal would work. It looks like the
|
Well they have the same id |
I'm not saying this is perfect, but it's still much better than the current mineflayer thing (https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L28) I don't know how the game knows the difference between Wither Skeletons and Skeletons |
Sounds like a similar problem as the one we are solving with blocks. Do Well they have the same id — |
Hmm I don't think they have metadata (https://github.com/andrewrk/mineflayer/blob/master/lib/entity.js), maybe it's just the equipment they wear ? |
ok maybe entities have metadata https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/protocol.js#L141 the value is not in the wiki though, so I'm going to ignore it for now (at least until we know something about it) |
some info about the metadata http://wiki.vg/Entities#Skeleton |
many kinds of spawn_* https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/protocol.js#L156 , what's an "entity" ? |
I added displayName in the end. I think this file is in a decent enough state to be used in mineflayer. Metadata information can be added afterwards (probably when it's done for items and blocks) |
I don't know if we really want to put metadata in that file. There's just the skeleton that has a simple variation. |
So yeah indeed, entity metadata is a functional thing. It should be handle case by case in mineflayer code, not in entities.json. File now integrated in mineflayer ! |
Currently we have that https://github.com/andrewrk/mineflayer/blob/master/lib/plugins/entities.js#L28
A lot of missing data compared to http://minecraft.gamepedia.com/Data_values/Entity_IDs
I propose a json like that :
It would also be possible to have one json file for every type of entity but that would be a lot of files, I think it's probably better to put everything in one file.
The text was updated successfully, but these errors were encountered: