1.20.3, 1.20.5 and 1.21.1 support #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flying-squid mostly updated to 1.21.1 after PrismarineJS/node-minecraft-protocol#1364. The remaining flaky tests are pretty much all due to zlib. I tried debugging this a bit but it's hard as it's not 100% clear exactly where the zlib errors are happening. As the zlib errors are thrown in c++ there is no JS stack context to rely on which makes it a pain, and also that they're async means it's not easy to log before/around all the zlib calls as something could be going on with the event loop. I think we could maybe move all the zlib to sync for some extra performance in the future. But for now it's not a big deal #664 and #668 and others will come with PrismarineJS/minecraft-data#948 with some refactoring |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PrismarineJS/node-minecraft-protocol#1364