Nuspec for Prism Windows 10 UWP (pre-release) packages #167
Conversation
Looking for a fix for automatically adding Prism.Windows dependency to Prism.Unity.Windows Todo: add files from project output to nuspec / AnyCPU for library
Was getting following error when adding Prism.Unity.Windows: Payload contains two or more files with the same destination path 'Prism.Windows\Properties\Prism.Windows.rd.xml'. Source files: C:\Users\bartl\.nuget\packages\Prism.Unity.Windows\6.0.0-prerelease002\lib\uap10.0\Prism.Windows\Properties\Prism.Windows.rd.xml C:\Users\bartl\.nuget\packages\Prism.Windows\6.0.0-prerelease001\lib\uap10.0\Prism.Windows\Properties\Prism.Windows.rd.xml HelloWorld.Unity
As discussed with Unni. Also mentioned on: http://blogs.msdn.com/b/dotnet/archive/2014/05/23/net-native-deep-dive-making-your-library-great.aspx And http://video.ch9.ms/sessions/build/2015/2-790.pptx slide 15
|
@brianlagunas after reviewing your change on the readme which includes the links to all NuGet packages, I started thinking (it happens ...). In this PR I've created a new NuGet package for Prism.Unity.Windows dll, but maybe this should be added to the existing Prism.Unity NuGet package (as we're using platform dependent paths in the package anyway). This to prevent a wild-grow of new packages, which will only get worse if we toss in Xamarin Forms and all possible containers. The downside is that releases of one of the 3 platforms will increase the version of the Unity package as well. Although for minor versions this shouldn't be much of a problem. What do you think? |
|
Yes, ideally we would use the same Prism.Unity package. Yeah, I have been trying to think of how we would do the versioning. I am thinking introducing the 4th version number only on the NuGet packages for those types of releases. So like 6.0.1.x where the "x" would identify an update in the assemblies in the package. Or something like that. |
|
I don't think people really pay attention to a version change that is 4th level deep, not sure if that would just add confusion. I think I would prefer to just have one NuGet that is platform adaptive rather than individual ones per platform, even if that means that people sometimes pull down an updated version that doesn't really change anything for them. We can make it clear in the release notes what it really affects. |
|
Not sure if NuGet will play well with a 4th digit, SemVer 2.0 isn't for anytime soon either. I'd say use the 3rd digit, as it's major.minor.patch so we aren't doing anything wrong in my eyes. @brianlagunas if you can add the existing nuspec files, I'll merge them. Or I'll just extract them from the packages when I got time later this week. |
|
I think we are going to stick with the v2 format for now. v3 is just a pain in the ass and doesn't play well with others :). v2 appears to work just fine with Universal apps, so we shouldn't run into any issues. Has anyone noticed any issues with using v2 for UWP? |
|
Could you update this PR with the changes made to the master? Then we can start looking at creating the new NuGets for the next minor release of Prism for WPF and the Preview for UWP. We will want the Prism.Unity package to include the DLL for WPF, UWP, and Xamarin Forms |
Fixed Conflicts: Source/PrismLibrary_Win10.sln Source/Windows10/Prism.Unity.Windows/Prism.Unity.Windows.csproj Source/Windows10/Prism.Windows.Tests/Prism.Windows.Tests.csproj Source/Windows10/Prism.Windows/Prism.Windows.csproj
|
Merged, back on track. |
|
Bart, sorry for taking so long to get to this one. Now it is showing branch conflicts. Could we ask you to update one more time and lets get this puppy merged? |
|
Haha sure. |
|
I'll merge this as-is to prevent more conflicts and open a new PR one of the next evenings with the merged NuSpec files with their correct dependencies (and not one per platform). |
Nuspec for Prism Windows 10 UWP (pre-release) packages
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Packages can be tested by adding this feed:
Don't forget to check for prerelease packages.
Closes #158